|
History
| Log In
|
|
|
|
[
Permlink
| « Hide
]
Mark Davis - 17/Mar/07 06:05 PM
this is an internal tools issue and doesn't warrant a release note
(trunk (4.1.x) r6893)
Checked on linux-builder and it is building twice. This issue is not actually preventing work or the builds from getting done, so I'm de-prioritizing it.
Fix sent to ptw for review: Change 20071105-ben-M Summary: Add a check to only build doc if it hasn't already been built
(Note that this is fixed in trunk!)
------------------------------------------------------------------------ r7183 | ben | 2007-11-07 11:48:40 -0800 (Wed, 07 Nov 2007) | 26 lines Changed paths: M /openlaszlo/trunk/build.xml Change 20071105-ben-M by ben@slim.local on 2007-11-05 10:58:31 PST in /Users/ben/src/svn/openlaszlo/trunk for http://svn.openlaszlo.org/openlaszlo/trunk Summary: Add a check to only build doc if it hasn't already been built New Features: faster distro build Bugs Fixed: Technical Reviewer: ptw QA Reviewer: mkratt (pending) Documentation: The dist-one target in build.xml previously built the documentation twice, which slowed down the build by >20 minutes, depending on architecture. This fix prevents the doc from building twice in the same invocation of ant, by setting a property doc.build.done after building the docs. Tests: Run ant dist-one in the nightly build. Search for docs/reference/index.html in the output. Before this change, it appeared twice, indicating that the docs had built twice. After this change, it only appears once, indicating that the docs only built once. (trunk4 build r7263)
doc is still building twice on the server. I just checked in another fix for this.
r7378 | ben | 2007-11-26 18:05:53 -0800 (Mon, 26 Nov 2007) | 36 lines Changed paths: M /openlaszlo/trunk/build.xml Change 20071126-ben-o by ben@slim.local on 2007-11-26 17:12:03 PST in /Users/ben/src/svn/openlaszlo/trunk-docbuild for http://svn.openlaszlo.org/openlaszlo/trunk Summary: Make doc build only build once on build machines. Bugs Fixed: Documentation: The doc build takes a lot of time, and doesn't work well on windows, at the moment, so we want fine control over when exactly to build it. This change adds logic so that we won't build the doc if we've already built it in this invocation of ant, if we're running on a windows box, or if we've set skip.doc to true. As before, if you just call $ ant doc it should build the doc. To skip building the doc, pass in -Dskip.doc=true, like this: $ ant -Dskip.doc=true build Most importantly, calling ant dist-one should build the docs exactly once. Tests: Run ant dist-one in the nightly build. Search for docs/reference/index.html in the output. Before this change, it appeared twice, indicating that the docs had built twice. After this change, it only appears once, indicating that the docs only built once. Also, verify that the windows build succeeded, and that it did not try to build the docs. r7396 | ben | 2007-11-27 17:04:50 -0800 (Tue, 27 Nov 2007) | 35 lines
Changed paths: M /openlaszlo/trunk/build.xml Change 20071127-ben-L by ben@slim.local on 2007-11-27 16:56:09 PST in /Users/ben/src/svn/openlaszlo/trunk-work-11-27-07-noon for http://svn.openlaszlo.org/openlaszlo/trunk Summary: Continued tweaks to the don't-build-doc-twice-in-nightly-build fix Bugs Fixed: (again, I hope) Technical Reviewer: ptw (pending) QA Reviewer: mkratt (pending) Documentation: When calling an ant target from script in an ant file, as I do in the "doc" target, it is a good idea to be thorough, if one wants the code to work on a variety of architectures. To accomplish this, we explicitly request a local variable for the ant tasks we are creating programmatically. This apparently keeps the parent build alive long enough that when the child build completes, the parent build can continue. Without explicitly saying "var myTask..." the parent build would terminate as soon as it invokes the child build, and we'd never get to finish the parent build. As before, the doc should not build if skip.doc is true, if the doc has already been built, or if the OS is windows. Tests: Run a nightly build. It should work, and the doc should only be built once. Already verified on linux-builder that we get through building the doc and on to the next task, checking for tabs. (In my environment, checking for tabs failed because I didn't have the path to python correct, but that's not what we're worrying about right now.) Before closing this, please verify that this works in the first build for trunk after r7396.
This is fixed, really fixed, conclusively fixed.
|
|||||||||||||||||||||||||||||||||||||||||||||||||
 |
|
Bug
Closed
P1
Refguide is being built twice on build machines.