|
History
| Log In
|
|
|
|
Based upon the notes attached to the bug, I performed a search through these text files to verify that unwanted text was removed and that desired text was implemented.
LzInputText.lzs - Use this.capabilities instead of this.sprite.capabilities and __warnCapability() instead of homespun warnings. Found: No 'this.sprite.capabilities' found. '__warnCapability()' was implelmented. LzText.lzs - Only set advanced text methods and setters in construct() if capabilities.advancedtext is true. Use this.capabilities instead of this.sprite.capabilities and __warnCapability() instead of homespun warnings. Found: No 'this.sprite.capabilities' found. 'this.capabilities' and '__warnCapability()' were implelmented. LaszloView.lzs - Expose LzSprite.prototype.capabilities as view.capabilities. Add shared __warnCapability() method. Use this.capabilities instead of this.sprite.capabilities and __warnCapability() instead of homespun warnings. Found: No 'this.sprite.capabilities'. 'this.capabilities' was implemented. '__warnCapability()' was implemented. Tests: 'ant lztest' and smoketest pass. Found: ant lztest built successfully. 'Smoketest' is a text file not an lzx file. Based upon the notes attached to the bug, I performed a search through these text files to verify that unwanted text was removed and that desired text was implemented.
LzInputText.lzs - Use this.capabilities instead of this.sprite.capabilities and __warnCapability() instead of homespun warnings. Found: No 'this.sprite.capabilities' found. '__warnCapability()' was implelmented. LzText.lzs - Only set advanced text methods and setters in construct() if capabilities.advancedtext is true. Use this.capabilities instead of this.sprite.capabilities and __warnCapability() instead of homespun warnings. Found: No 'this.sprite.capabilities' found. 'this.capabilities' and '__warnCapability()' were implelmented. LaszloView.lzs - Expose LzSprite.prototype.capabilities as view.capabilities. Add shared __warnCapability() method. Use this.capabilities instead of this. sprite.capabilities and __warnCapability() instead of homespun warnings. Found: No 'this.sprite.capabilities'. 'this.capabilities' was implemented. '__warnCapability()' was implemented. Tests: 'ant lztest' and smoketest pass. Found: ant lztest built successfully. 'Smoketest' is a text file not an lzx file. In addition to the text findings above, both tests: 'ant lztest' and smoketest passed. Bug closed.
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||
 |
|
Bug
Closed
P0
Missing warnings in "LzBrowser.js" (DHTML)
Date: 2007-08-17 17:14:47 -0700 (Fri, 17 Aug 2007)
New Revision: 6137
Modified:
openlaszlo/branches/wafflecone/WEB-INF/lps/lfc/views/LaszloCanvas.lzs
Log:
Should have been part of r6136...
Change 20070817-maxcarlson-L by maxcarlson@plastik on 2007-08-17 13:21:33 PDT
in /Users/maxcarlson/openlaszlo/wafflecone
for http://svn.openlaszlo.org/openlaszlo/branches/wafflecone
Summary: Unify capability warnings across runtimes
New Features:
Bugs Fixed:
LPP-4200- Missing warnings in "LzBrowser.js" (DHTML)Technical Reviewer: promanik
QA Reviewer: ben
Doc Reviewer: (pending)
Documentation:
Release Notes:
Details: LzInputText.lzs - Use this.capabilities instead of this.sprite.capabilities and __warnCapability() instead of homespun warnings.
LzText.lzs - Only set advanced text methods and setters in construct() if capabilities.advancedtext is true. Use this.capabilities instead of this.sprite.capabilities and __warnCapability() instead of homespun warnings.
LaszloView.lzs - Expose LzSprite.prototype.capabilities as view.capabilities. Add shared __warnCapability() method. Use this.capabilities instead of this.
sprite.capabilities and __warnCapability() instead of homespun warnings.
Tests: 'ant lztest' and smoketest pass.
Files:
M WEB-INF/lps/lfc/views/LzInputText.lzs
M WEB-INF/lps/lfc/views/LzText.lzs
M WEB-INF/lps/lfc/views/LaszloView.lzs
Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070817-maxcarlson-L.tar
Modified: openlaszlo/branches/wafflecone/WEB-INF/lps/lfc/views/LaszloCanvas.lzs
===================================================================
--- openlaszlo/branches/wafflecone/WEB-INF/lps/lfc/views/LaszloCanvas.lzs 2007-08-18 00:13:09 UTC (rev 6136)
+++ openlaszlo/branches/wafflecone/WEB-INF/lps/lfc/views/LaszloCanvas.lzs 2007-08-18 00:14:47 UTC (rev 6137)
@@ -117,7 +117,7 @@
if (args.width.charAt(args.width.length-1) == '%') {
var percent = Number(args.width.substr(0, args.width.length-1));
this.__canvaswidthratio = percent/100;
- if (this.sprite.capabilities.scalecanvastopercentage != true) {
+ if (this.capabilities.scalecanvastopercentage != true) {
// some runtimes already scale the viewport size, so take the reported size literally to avoid scaling twice
this.__canvaswidthratio = 1;
}
@@ -136,7 +136,7 @@
if (args.height.charAt(args.height.length-1) == '%') {
var percent = Number(args.height.substr(0, args.height.length-1));
this.__canvasheightratio = percent/100;
- if (this.sprite.capabilities.scalecanvastopercentage != true) {
+ if (this.capabilities.scalecanvastopercentage != true) {
// some runtimes already scale the viewport size, so take the reported size literally to avoid scaling twice
this.__canvasheightratio = 1;
}
_______________________________________________
Laszlo-checkins mailing list
Laszlo-checkins@openlaszlo.org
http://www.openlaszlo.org/mailman/listinfo/laszlo-checkins