History | Log In     View a printable version of the current page.  
Issue Details (XML | Word | Printable)

Key: LPP-4370
Type: Bug Bug
Status: Verified Verified
Resolution: Fixed
Priority: -- --
Assignee: Unassigned
Reporter: Benjamin Shine
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
OpenLaszlo

drawview doesn't respect visibility

Created: 26/Jul/07 04:49 PM   Updated: 22/Oct/07 11:13 AM
Component/s: Extensions - drawview
Affects Version/s: 4.0.3
Fix Version/s: 4.0.5WaffleCone

Time Tracking:
Not Specified

File Attachments: 1. File LPP-4370.lzx (1 kb)

Environment: Firefox

Severity: Minor
Fixed in Change#: 6,175
Runtime: N/A
Flags: External
Fix in hand: False


 Description  « Hide
Try this example code under 4.0.3 swf8 and you'll see that the views are visible even though we make every effort to make them not visible. Furthermore, using the debugger calling inner.setVisible(false); has no effect whereas calling outer.setVisible(false); does.
 
<canvas proxied="false">
    <class name="Foo" extends="drawview" visible="false"
        bgcolor="red"
    >
        <method name="_redraw">
            Debug.write("VISIBLE: " + this.visible);
            this.clear();
           
            this.beginPath();
            this.moveTo(0, 0);
            this.lineTo(this.width, 0);
            this.lineTo(this.width, this.height);
            this.lineTo(0, this.height);
            this.closePath();
           
            this.fillStyle = 0x00ff00;
            this.fill();
        </method>
    </class>
   
    <Foo x="100" y="100" width="100" height="100" visible="false">
        <method event="oninit">
            _redraw();
            setVisible(false);
        </method>
    </Foo>
   
    <Foo x="200" y="100" width="100" height="100" visible="false">
        <!-- No drawing means we don't see the view. -->
    </Foo>
   
    <view id="outer">
        <Foo id="inner" x="100" y="200" width="100" height="100" visible="false">
            <method event="oninit">
                _redraw();
                setVisible(false);
            </method>
        </Foo>
    </view>
</canvas>
 

 All   Comments   Work Log   Change History      Sort Order: Ascending order - Click to sort in descending order
Benjamin Shine - 26/Jul/07 04:49 PM
Reported by Maynard Demmon, mdemmon@laszlosystems.com

Benjamin Shine - 26/Jul/07 04:51 PM
This was working in 4.0.2, but not in 4.0.3.
It was happening on a PC.

Max Carlson - 21/Aug/07 06:53 PM
Author: max
Date: 2007-08-21 18:51:46 -0700 (Tue, 21 Aug 2007)
New Revision: 6175

Modified:
   openlaszlo/branches/wafflecone/lps/components/extensions/drawview.lzx
Log:
Change 20070821-maxcarlson-N by maxcarlson@plastik on 2007-08-21 17:59:00 PDT
    in /Users/maxcarlson/openlaszlo/wafflecone
    for http://svn.openlaszlo.org/openlaszlo/branches/wafflecone

Summary: Make swf drawviews respec visible attribute

New Features:

Bugs Fixed: LPP-4370 - drawview doesn't respect visibility

Technical Reviewer: ben
QA Reviewer: jcrowley
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details: Reset visibility to the value of thie visible attribute.
    

Tests: See LPP-4370.



Modified: openlaszlo/branches/wafflecone/lps/components/extensions/drawview.lzx
===================================================================
--- openlaszlo/branches/wafflecone/lps/components/extensions/drawview.lzx 2007-08-22 01:00:44 UTC (rev 6174)
+++ openlaszlo/branches/wafflecone/lps/components/extensions/drawview.lzx 2007-08-22 01:51:46 UTC (rev 6175)
@@ -734,7 +734,7 @@
                         m.curveTo(op[1], op[2], op[3], op[4]);
                     }
                 }
- this.context._visible = true;
+ this.context._visible = this.visible;
             }
     
             function clip () {


_______________________________________________
Laszlo-checkins mailing list
Laszlo-checkins@openlaszlo.org
http://www.openlaszlo.org/mailman/listinfo/laszlo-checkins

Steve O'Sullivan - 22/Oct/07 11:13 AM
Tested in Firefox 2.0.0.8 on windows against r6938 trunk. No views are visible which is the expected behavior for this script.