[#LPP-4543] setVisibility was not an approved API change

OpenLaszlo

setVisibility was not an approved API change

Created: 21/Aug/07 03:09 AM Updated: 24/Oct/07 12:56 PM

Component/s:

Laszlo Foundation Classes (LFC)

Affects Version/s:

4.0.5WaffleCone

Fix Version/s:

4.0.5WaffleCone

Time Tracking:

Not Specified

Severity:	Minor
Fixed in Change#:	6,277
Runtime:	N/A
Flags:	Products
Fix in hand:	False

Description

« Hide

File a bug to propose (and if accepted, implement) the setVisibility API change.

Mark visibility onvisibility, and setVisibility as @access private (so they don't show up in the documentation).

Comment out the deprecated warning in setVisible.

While you are there, it seems to me that the ordering of __LZupdateShown and onvisibility.sendEvent should be the same in setVisible and setVisibility.

All

Comments

Work Log

Change History

Sort Order:

Ascending order - Click to sort in descending order

[ Permlink | « Hide ]

Amy Muntz - 28/Aug/07 11:22 AM

Please take this one - Tucker wants to review. File another bug to get the api approved for 4.1. Questions to Tucker.

[ Permlink | « Hide ]

Josh Crowley - 28/Aug/07 01:14 PM

Proposal is bug LPP-4599.

[ Permlink | « Hide ]

Josh Crowley - 29/Aug/07 10:58 AM

Approved by Tucker.

[ Permlink | « Hide ]

P T Withington - 29/Aug/07 12:40 PM

r6277 | jcrowley | 2007-08-29 13:57:53 -0400 (Wed, 29 Aug 2007) | 29 lines
Changed paths:
   M /openlaszlo/branches/wafflecone/WEB-INF/lps/lfc/views/LaszloView.lzs

Change 20070829-jcrowley-P by jcrowley@doctormanhattan.mshome.net on 2007-08-29 00:26:11 EDT
    in /Users/jcrowley/src/svn/openlaszlo/waffle
    for http://svn.openlaszlo.org/openlaszlo/branches/wafflecone

Summary: setVisibility was not an approved API change

New Features:

Bugs Fixed: ~~LPP-4543~~

Technical Reviewer: ptw
QA Reviewer: (pending)
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details: Commented out warning, changed visibility stuff in
view to @access private. Fixed ordering of setVisibility
to match setVisible.

Tests: Build docs, note absence of setVisibility and related
elements from the refguide for View. Run the Calendar
demo with debug=true, click the "i" to open up the info
panel, note an absence of warnings about "setVisibility"
in the Debugger.

[ Permlink | « Hide ]

Mamye Kratt - 24/Oct/07 12:56 PM

(trunk4 local build r6967)
Closed