[#LPP-4610] 'request' method is deprecated, causing trouble, needs to be removed for LzDataset

OpenLaszlo

'request' method is deprecated, causing trouble, needs to be removed for LzDataset

Created: 29/Aug/07 04:22 PM Updated: 23/Oct/07 10:49 AM

Component/s:

LFC - Data

Affects Version/s:

4.0.5WaffleCone

Fix Version/s:

4.0.5WaffleCone

Time Tracking:

Not Specified

File Attachments:

LPP-4610.lzx (0.4 kb)

Severity:	Major
Fixed in Change#:	6,289
Runtime:	N/A
Fix in hand:	True

Description

« Hide

Pablo wants to be able to read 'request' attribute on dataset, and it is being used for an old alias for doRequest

fix: remove the alias, fix the setter to actually set the attribute value of 'request'

All

Comments

Work Log

Change History

Sort Order:

Ascending order - Click to sort in descending order

[ Permlink | « Hide ]

Henry Minsky - 30/Aug/07 06:32 AM

r6289 | hqm | 2007-08-30 09:30:50 -0400 (Thu, 30 Aug 2007) | 36 lines
Changed paths:
   M /openlaszlo/branches/wafflecone/WEB-INF/lps/lfc/data/LzDataset.lzs
   M /openlaszlo/branches/wafflecone/WEB-INF/lps/schema/lzx.rnc

Change 20070829-hqm-0 by hqm@IBM-2E06404CB67 on 2007-08-29 19:22:14 EDT
    in /cygdrive/c/users/hqm/openlaszlo/wafflecone3
    for http://svn.openlaszlo.org/openlaszlo/branches/wafflecone

Summary: fix 'request' attribute in dataset

New Features:

Bugs Fixed: ~~LPP-4610~~
Bug: ~~LPP-4610~~

Technical Reviewer: pkang
QA Reviewer: pbr
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details:

the 'request' attribute was being aliased to the doRequest() method, to support
the deprecated 'request()' method name.

Change this to be a regular attribute

Tests:

test/lfc/data/alldata.lzx (swf, dhtml)

test/smoke

------------------------------------------------------------------------

[ Permlink | « Hide ]

Steve O'Sullivan - 23/Oct/07 10:48 AM

Based upon the exchange between Henry and I (below), I ran the suggested test case and got the expected behavior. This bug is verified.

Thanks Henry!

-----------------------------------------------------

A test case would be

http://127.0.0.1:8080/trunk/test/lpp-4610.lzx

<canvas width="100%" height="80%" debug="true">
  <debug fontsize="12"/>

  <dataset name='foo1' request="true" type="http"
           src="resources/xml/textnodes.xml"/>

  <dataset name='foo2' request="false" type="http"
           src="resources/xml/textnodes.xml"/>

  <script>
    Debug.write("foo1.request should be true", foo1.request);
    Debug.write("foo2.request should be false", foo2.request);

  </script>

</canvas>

Don't worry about the data file it's loading, it's not important if it exists,
just that the value of the 'request' attribute reflects the value set in the
LZX tags.

Don't worry about the error

On 10/23/07, Steve O'Sullivan <sosullivan@laszlosystems.com > wrote:
> Hello,
>
> I am looking at this bug with an eye toward verifying it as fixed. I see
> the test case that you have included (test/lfc/data/alldata.lzx (swf,
> dhtml)), however, I need you to please explain what behavior I should be
> looking for in a failure case, and a successful case.
>
> Thanks for any and all assistance.
>
> Regards,
>
>
> SteveO
>
--
Henry Minsky
Software Architect
hminsky@laszlosystems.com